Implemented IPAM Range #48
Conversation
| state: "absent" | ||
| ignore_errors: true | ||
|
|
||
| - name: "Delete IP Space" |
There was a problem hiding this comment.
Can we have a standardized cleanup file in setup_ip_space instead of this and call that from here ?
Something like :
- ansible.builtin.include_role:
name: "setup_ip_space"
tasks_from: "cleanup.yml"
| """ | ||
|
|
||
| EXAMPLES = r""" | ||
| - name: Retrieve range information by ID |
There was a problem hiding this comment.
| - name: Retrieve range information by ID | |
| - name: Get Range information by ID |
| ipam_range_info: | ||
| id: "range-id-12345" | ||
|
|
||
| - name: Retrieve range information with filters |
There was a problem hiding this comment.
| - name: Retrieve range information with filters | |
| - name: Get Range information with filters (eg. start , end) |
| start: "192.168.1.0" | ||
| end: "192.168.1.255" | ||
|
|
||
| - name: Retrieve range information with filter query |
There was a problem hiding this comment.
| - name: Retrieve range information with filter query | |
| - name: Get Range information with filter query |
| - name: Retrieve range information with filter query | ||
| ipam_range_info: | ||
| filter_query: "start=='10.0.0.1' and end=='10.0.0.100'" | ||
| """ |
There was a problem hiding this comment.
Can you add an examples of filtering using Tag Filters ?
| type: dict | ||
| returned: Always | ||
| contains: | ||
| abandoned: |
There was a problem hiding this comment.
Update descriptions please !
| - infoblox.bloxone.common | ||
| """ | ||
| EXAMPLES = r""" | ||
| - name: "Create an Ip Space" |
There was a problem hiding this comment.
| - name: "Create an Ip Space" | |
| - name: "Create an IP Space" |
| space: "{{ ip_space.id }}" | ||
| state: "present" | ||
|
|
||
| - name: "Create a Range" |
There was a problem hiding this comment.
Woudnt it be a better idea to split the create example into 2 parts , one consisting of only the necessart fields and one with additional fields , something like done with IPAM Host .
https://github.com/VishrutiBuddhadev/bloxone-ansible/blob/4af66b30adfd2c564838c69822984dc2bbaf48ec/plugins/modules/ipam_host.py#L112
| id: "range-id-12345" | ||
|
|
||
| - name: Retrieve range information with filters | ||
| ipam_range_info: |
There was a problem hiding this comment.
| ipam_range_info: | |
| infoblox.bloxone.ipam_range_info: |
| @@ -0,0 +1,297 @@ | |||
| --- | |||
| # TODO: Add tests for DHCP Options the ipam_range module | |||
There was a problem hiding this comment.
Why is DHCP Options added to TODO ?
| tags: | ||
| location: "{{ tag_value }}" | ||
| state: "present" | ||
| register: ip_range |
There was a problem hiding this comment.
it should be either "ipam_range" or "range"
| api_key: "{{ api_key }}" | ||
|
|
||
| block: | ||
| - name: "Delete IP Space" |
There was a problem hiding this comment.
| - name: "Delete IP Space" | |
| - name: "Delete Subnet" |
|
|
||
| block: | ||
| - name: "Delete IP Space" | ||
| infoblox.bloxone.ipam_ip_space: |
There was a problem hiding this comment.
| infoblox.bloxone.ipam_ip_space: | |
| infoblox.bloxone.ipam_subnet: |
| block: | ||
| - name: "Delete IP Space" | ||
| infoblox.bloxone.ipam_ip_space: | ||
| name: "{{ name }}" |
There was a problem hiding this comment.
| name: "{{ name }}" | |
| address: "10.0.0.0/24" | |
| space: "{{ _ip_space.id }}" |
Implemented IPAM Range